Re: Warning compiling pg_dump (MinGW, Windows XP)

On 01/17/2011 05:54 AM, Pavel Golub wrote:
> Hello, Robert.
>
> You wrote:
>
> RH> 2011/1/13 Pavel Golub<pavel(at)microolap(dot)com>:
>>> Hello, Pgsql-hackers.
>>>
>>> I'm getting such warnings:
>>>
>>> pg_dump.c: In function 'dumpSequence':
>>> pg_dump.c:11449:2: warning: unknown conversion type character 'l' in format
>>> pg_dump.c:11449:2: warning: too many arguments for format
>>> pg_dump.c:11450:2: warning: unknown conversion type character 'l' in format
>>> pg_dump.c:11450:2: warning: too many arguments for format
>>>
>>> Line numbers my not be the same in the official sources, because I've
>>> made some changes. But the lines are:
>>>
>>> snprintf(bufm, sizeof(bufm), INT64_FORMAT, SEQ_MINVALUE);
>>> snprintf(bufx, sizeof(bufx), INT64_FORMAT, SEQ_MAXVALUE);
>>>
>>> In my oppinion configure failed for MinGw+Windows in this case. Am I
>>> right? Can someone give me a hint how to avoid this?
> RH> It seems like PGAC_FUNC_SNPRINTF_LONG_LONG_INT_FORMAT is getting the
> RH> wrong answer on your machine, though I'm not sure why. The easiest
> RH> workaround is probably to run configure and then edit
> RH> src/include/pg_config.h before compiling.
>
> Thanks Robert. What value should I enter for this option?

Mingw has always had a huge number of format warnings. See for example
<http://www.pgbuildfarm.org/cgi-bin/show_stage_log.pl?nm=frogmouth&dt=2011-01-17%2007%3A30%3A00&stg=make>

If someone wants to fix them that would be good, but I'm not sure it's a
simple task. There's probably some discussion of it in the archives back
when we first did the Windows port.

cheers

andrew