From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Add support for logging the current role |
Date: | 2011-01-15 16:18:59 |
Message-ID: | 4D31C8F3.6090709@dunslane.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 01/15/2011 11:08 AM, Tom Lane wrote:
> Robert Haas<robertmhaas(at)gmail(dot)com> writes:
>> On Fri, Jan 14, 2011 at 9:24 PM, Andrew Dunstan<andrew(at)dunslane(dot)net> wrote:
>>> What's your suggestion, then?
>> If there's a practical way to add the requested escape, add it to the
>> text format and leave reengineering the CSV format for another day.
>> Yeah, I know that's not the most beautiful solution in the world, but
>> we're doing engineering here, not theology.
> Well, the original patch was exactly that. But I don't agree with that
> approach; I think allowing the capabilities of text and CSV logs to
> diverge significantly would be a mistake. If a piece of information is
> valuable enough to need a way to include it in textual log entries,
> then you need a way to include it in CSV log entries too. If it's not
> valuable enough to do the work to support it in CSV, then we can live
> without it.
>
>
Yeah, I agree, that's exactly the kind of divergence we usually try to
avoid. And it's hardly theology to say let's not do a half-assed job on
this.
cheers
andrew
From | Date | Subject | |
---|---|---|---|
Next Message | Greg Smith | 2011-01-15 16:52:52 | Re: auto-sizing wal_buffers |
Previous Message | Peter Eisentraut | 2011-01-15 16:15:45 | Re: log_hostname and pg_stat_activity |