| From: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: and it's not a bunny rabbit, either |
| Date: | 2010-12-29 09:09:56 |
| Message-ID: | 4D1AFAE4.4010305@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 29.12.2010 06:54, Robert Haas wrote:
> With the patch:
>
> rhaas=# cluster v;
> ERROR: views do not support CLUSTER
"do not support" sounds like a missing feature, rather than a
nonsensical command. How about something like "CLUSTER cannot be used on
views"
The patch changes a bunch of heap_openrv() calls to relation_openrv().
Perhaps it would be better make the error message something like "\"%s\"
is not a table", and keep the callers unchanged. It's not particularly
useful to repeat the command in the error message, the user should know
what command he issued. Even if it's buried deep in a PL/pgSQL function
or something, it should be clear from the context lines.
--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Yeb Havinga | 2010-12-29 09:19:44 | Re: "writable CTEs" |
| Previous Message | Heikki Linnakangas | 2010-12-29 08:51:42 | Re: pg_primary_conninfo |