Re: Instrument checkpoint sync calls

From: Greg Smith <greg(at)2ndquadrant(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Magnus Hagander <magnus(at)hagander(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Instrument checkpoint sync calls
Date: 2010-12-16 11:48:17
Message-ID: 4D09FC81.5080700@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Robert Haas wrote:
> On Wed, Dec 15, 2010 at 9:22 AM, Greg Smith <greg(at)2ndquadrant(dot)com> wrote:
>
>> patch I submit. Doesn't seem worth going through the trouble of committing
>> that minor rework on its own, I'll slip it into the next useful thing that
>> touches this area I do. Thanks for the hint, this would work better than
>> what I did.
>>
>
> Well, if I'm the one committing it, I'll pull that part out again and
> commit it separately. Not sure if that affects your calculus, but I
> much prefer patches that don't try to do ancillary things along the
> way.
>

I meant that I'd bundle it into the block of time I spend on that, and
likely submit with something else that touches the same area. Obviously
the correction patch would be better on its own when being handed over
to a committer.

--
Greg Smith 2ndQuadrant US greg(at)2ndQuadrant(dot)com Baltimore, MD
PostgreSQL Training, Services and Support www.2ndQuadrant.us
"PostgreSQL 9.0 High Performance": http://www.2ndQuadrant.com/books

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2010-12-16 12:21:42 Re: proposal: auxiliary functions for record type
Previous Message Florian Pflug 2010-12-16 11:39:27 Re: proposal: auxiliary functions for record type