| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Magnus Hagander <magnus(at)hagander(dot)net>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com>, Hiroshi Inoue <inoue(at)tpf(dot)co(dot)jp>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Complier warnings on mingw gcc 4.5.0 |
| Date: | 2010-12-15 18:59:41 |
| Message-ID: | 4D09101D.50108@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 12/15/2010 12:28 PM, Andrew Dunstan wrote:
>
>
>
> I think you're probably right. narwhal reports having optreset, but my
> Mingw reports not having it, so this looks like a likely culprit.
And the attached hack allowed "make check" to succeed.
I think the logic in tcop/postgres.c and postmaster/postmaster.c is
probably wrong. If we are using our getopt/getopt_long, we want to be
setting optreset, whether or not configure found one in the system
libraries.
cheers
andrew
| Attachment | Content-Type | Size |
|---|---|---|
| getopt-hack | text/plain | 1.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2010-12-15 19:06:57 | Re: Complier warnings on mingw gcc 4.5.0 |
| Previous Message | Merlin Moncure | 2010-12-15 18:56:10 | Re: getting composite types info from libpq |