Re: BUG #15788: 'pg_dump --create' orders database GRANTs incorrectly

From: "Bossart, Nathan" <bossartn(at)amazon(dot)com>
To: Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>
Cc: "pgsql-bugs(at)lists(dot)postgresql(dot)org" <pgsql-bugs(at)lists(dot)postgresql(dot)org>
Subject: Re: BUG #15788: 'pg_dump --create' orders database GRANTs incorrectly
Date: 2019-05-03 17:22:47
Message-ID: 4D066CB2-B177-40B4-8510-9318B9A184CE@amazon.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On 5/1/19, 9:10 PM, "Haribabu Kommi" <kommi(dot)haribabu(at)gmail(dot)com> wrote:
> On Thu, May 2, 2019 at 9:28 AM Bossart, Nathan <bossartn(at)amazon(dot)com> wrote:
>> It looks like the bug reporting form destroyed the patch. I've
>> attached it again here.
>
> Thanks, for the patch. Just to make sure that we didn't miss, a similar problem
> can occur in v10 and v9.6 pg_dumpall. In v11, the database acl's dumping
> mechanism is moved from pg_dumpall to pg_dump.
>
> a similar change in pg_dumpall "dumpCreateDB" function works for 10 and 9.6.

Thanks for taking a look. I've attached all the versions of the patch
needed to back-patch this down to 9.6, where this query was
introduced.

Nathan

Attachment Content-Type Size
v2-0001-Fix-ordering-of-GRANTs-for-databases-in-pg_dump-master-v11.patch application/octet-stream 2.0 KB
v2-0001-Fix-ordering-of-GRANTs-for-databases-in-pg_dump-v9.6.patch application/octet-stream 2.1 KB
v2-0001-Fix-ordering-of-GRANTs-for-databases-in-pg_dump-v10.patch application/octet-stream 2.2 KB

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message José Luis Viejo 2019-05-04 05:11:51 identity not working with inherited table
Previous Message Prakash Ramakrishnan 2019-05-03 12:45:05 Re: orafce bug issue