| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: allow COPY routines to read arbitrary numbers of fields |
| Date: | 2010-12-06 18:36:37 |
| Message-ID: | 4CFD2D35.2060801@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 12/06/2010 01:23 PM, Tom Lane wrote:
> Andrew Dunstan<andrew(at)dunslane(dot)net> writes:
>> On 12/06/2010 12:11 PM, Tom Lane wrote:
>>> Also, why did you change the setup code to
>>> not compute nfields in binary mode? That seems at best an unnecessary
>>> change, and at worst a breakage of the binary path --- did you test it?
>> AFAICT it's not used in binary mode at all. But I will double check.
> Well, even if it is not used at the moment, it seems potentially of use
> in that path. So I'd vote for continuing to set it correctly, rather
> than making it deliberately incorrect as this patch is going out of its
> way to do.
>
>
Ok.
cheers
andrew
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2010-12-06 18:43:32 | Re: pg_execute_from_file review |
| Previous Message | Kevin Grittner | 2010-12-06 18:28:39 | Re: WIP patch for parallel pg_dump |