| From: | Greg Smith <greg(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Instrument checkpoint sync calls |
| Date: | 2010-11-15 20:09:31 |
| Message-ID: | 4CE1937B.60603@2ndquadrant.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
So my task list is:
0) Rebase against the HEAD that just code related to this touched today
1) Assume that log_checkpoints is sufficient control over whether the
timing overhead added is worth collecting, and therefore remove the
half-baked idea of also wrapping with a compile-time option.
2) Have the sync summary returned upwards, so it can be put onto the
same line as the rest of the rest of the log_checkpoint info.
All seems reasonable to me. Will rev a new patch by tomorrow.
--
Greg Smith 2ndQuadrant US greg(at)2ndQuadrant(dot)com Baltimore, MD
PostgreSQL Training, Services and Support www.2ndQuadrant.us
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2010-11-15 20:19:00 | Re: Instrument checkpoint sync calls |
| Previous Message | Tom Lane | 2010-11-15 19:48:21 | Re: Instrument checkpoint sync calls |