| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Jan Urbański <wulczer(at)wulczer(dot)org>, Postgres - Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: why does plperl cache functions using just a bool for is_trigger |
| Date: | 2010-10-31 18:00:41 |
| Message-ID: | 4CCDAEC9.6030504@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 10/31/2010 11:44 AM, Tom Lane wrote:
> =?UTF-8?B?SmFuIFVyYmHFhHNraQ==?=<wulczer(at)wulczer(dot)org> writes:
>> Seems that this circumverts some output conversion error checking, since
>> adding the attached to the regression suite results in a segfault during
>> the plperl installcheck.
>> Reverting 2d01ec0708d571eef926f3f5795aa73759df5d9a fixes it.
> Good catch, patch reverted (and regression test added).
Well, I guess that answers the question of why we needed it, which
nobody could answer before. I'm not sure I exactly understand what's
going on here, though - I guess I need to look at it closer. At least I
think we need a code comment on why the trigger flag is needed as part
of the hash key.
cheers
andrew
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dimitri Fontaine | 2010-10-31 18:19:08 | Re: ALTER OBJECT any_name SET SCHEMA name |
| Previous Message | Heikki Linnakangas | 2010-10-31 17:46:31 | Re: ALTER OBJECT any_name SET SCHEMA name |