| From: | Marko Tiikkaja <marko(dot)tiikkaja(at)cs(dot)helsinki(dot)fi> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Steve Singer <ssinger_pg(at)sympatico(dot)ca>, pgsql-hackers(at)postgresql(dot)org, Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
| Subject: | Re: Review: Fix snapshot taking inconsistencies |
| Date: | 2010-10-21 12:32:54 |
| Message-ID: | 4CC032F6.5000803@cs.helsinki.fi |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
Here's an updated patch.
I'm still not too fond of the logic in spi.c, but I can't see a better
way to do this. If someone sees a better way, I'm not going to object.
I also made some changes to the SQL functions now that we have a
different API. The previous code pushed and popped snapshots quite heavily.
I'd also like to see more regression tests for SQL functions, but I'm
going to submit my suggestions as a separate patch.
Regards,
Marko Tiikkaja
| Attachment | Content-Type | Size |
|---|---|---|
| snapshot4.patch | text/plain | 27.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2010-10-21 13:57:42 | Re: UNION ALL has higher cost than inheritance |
| Previous Message | Jean-Baptiste Quenot | 2010-10-21 12:20:16 | Bug in plpython's Python Generators |