Re: [PATCH] Fix CREATE INDEX/CONSTRAINT syntax when tablespace and fillfactor are specified

From: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
To: Marti Raudsepp <marti(at)juffo(dot)org>
Cc: pgAdmin hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Fix CREATE INDEX/CONSTRAINT syntax when tablespace and fillfactor are specified
Date: 2010-10-06 19:18:39
Message-ID: 4CACCB8F.2070003@lelarge.info
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Le 06/10/2010 00:25, Guillaume Lelarge a écrit :
> Hi Marti,
>
> Le 05/10/2010 23:33, Marti Raudsepp a écrit :
>> [...]
>> Quite recently I stumbled upon this bug in pgAdminIII and today I was
>> reading Guillaume Lelarge's article about pgAdmin's git repository and
>> this is the result. :)
>>
>
> That's just great. I didn't expect that someone would use this blog post
> so quickly. And you don't appear to be alone:
> http://github.com/postgres/pgadmin3/network
>
>> The patch is attached, or you can also get it at
>> http://github.com/intgr/pgadmin3 branch "mybugfix"
>>
>
> OK, nice work. I'll check this tomorrow. Thanks for your work.
>

Done, and commited. I also commited a substract of your patch on the
1.12 branch (we didn't have the tablespace issue in the index constraint
back in 1.12).

Thanks again.

--
Guillaume
http://www.postgresql.fr
http://dalibo.com

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message pgAdmin Trac 2010-10-06 19:33:10 [pgAdmin III] #251: Fix CREATE INDEX/CONSTRAINT syntax when tablespace and fillfactor are specified
Previous Message Guillaume Lelarge 2010-10-06 19:14:38 pgAdmin III commit: Fix CREATE INDEX/CONSTRAINT syntax when tablespace