Re: pgAdmin III commit: Fix log_statement query in frmStatus

From: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
To: pgadmin-hackers(at)postgresql(dot)org
Subject: Re: pgAdmin III commit: Fix log_statement query in frmStatus
Date: 2010-09-29 08:50:56
Message-ID: 4CA2FDF0.5090104@lelarge.info
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Le 29/09/2010 00:26, Guillaume Lelarge a écrit :
> Fix log_statement query in frmStatus
>
> log_statement cannot be true or false, it will depends on the work we gave you.
>

I don't know what went wrong with this commit message. Must be me being
too tired.

As I can't change it, I'll try to explain it a bit more here.

log_statement parameter is of type boolean in 7.4, and was changed to
text/enum since 8.0. So, we got query error when we tried to disable log
statements in the server status window. The patch fixes this by changing
the query we execute wrt the PostgreSQL release.

--
Guillaume
http://www.postgresql.fr
http://dalibo.com

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Guillaume Lelarge 2010-09-29 16:55:40 pgAdmin III commit: Fix the double line number in the function props
Previous Message Guillaume Lelarge 2010-09-28 22:42:03 pgAdmin III commit: Fix the CHANGELOG file.