From: | Steffen Kuhn <pg(at)kuhnsteffen(dot)de> |
---|---|
To: | Guillaume Lelarge <guillaume(at)lelarge(dot)info> |
Cc: | pgadmin-hackers(at)postgresql(dot)org |
Subject: | Re: #229 |
Date: | 2010-09-23 19:11:42 |
Message-ID: | 4C9BA66E.6070608@kuhnsteffen.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi Guillaume,
actually I wanted to tooltip 'De-/Select all ...' ;-)
My intension was do bring the benefit with less code, logic and
dependencies,
but anyway if it feels not good here the next try.
Added some pixel-pimped images - just have a look at.
Regards Steffen
Am 20.09.2010 22:34, schrieb Guillaume Lelarge:
> Le 18/09/2010 06:57, Steffen Kuhn a écrit :
>
>> Hi Gullaime,
>>
>> please find patch for #229 attached.
>>
>>
> Patch seems fine. I think the icon should get changed when the action
> changes. I mean, you click on the button, everything is selected and I
> kind of expected that the icon would changed too (with an unselect
> icon). It's a bit nitty-picky, but I think it's worth it.
>
> Anyway, even if the icon doesn't change, the tooltip should get changed.
>
> Both of them should be easy to do. Will commit as soon as this is fixed.
>
> Thanks for your work.
>
>
>
Attachment | Content-Type | Size |
---|---|---|
#229.work.patch | text/x-patch | 11.2 KB |
uncheck.xpm | image/x-xpixmap | 1.6 KB |
pixel.pimp.tar.gz | application/x-gzip | 8.6 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | git | 2010-09-23 20:12:34 | pgAdmin III commit: Branch refs/heads/mybugfixwork was created |
Previous Message | pgAdmin Trac | 2010-09-23 18:08:06 | Re: [pgAdmin III] #238: pgAdmin 1.12.0 crashes when displaying properties panel |