| From: | "Bossart, Nathan" <bossartn(at)amazon(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | Chapman Flack <chap(at)anastigmatix(dot)net>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: improve CREATE EXTENSION error message |
| Date: | 2021-11-29 22:13:02 |
| Message-ID: | 4C99C463-E3C9-4816-AD34-F5DAB8BED54F@amazon.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 11/29/21, 2:04 PM, "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> I think "The extension must ..." would read better, otherwise +1.
>
> I don't especially like intertwining the hint choice with the existing
> special case for per-version files. Our usual style for conditional
> hints can be found in places like sysv_shmem.c, and following that
> would lead to a patch roughly like
Alright, here's v3. In this version, I actually removed the message
about the control file entirely, so now the error message looks like
this:
postgres=# CREATE EXTENSION does_not_exist;
ERROR: extension "does_not_exist" is not available
DETAIL: The extension must first be installed on the system where PostgreSQL is running.
HINT: The pg_available_extensions view lists the extensions that are available for installation.
I can add the control file part back if we think it's necessary.
Nathan
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-Improve-CREATE-EXTENSION-error-message.patch | application/octet-stream | 1.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bossart, Nathan | 2021-11-29 22:18:48 | Re: improve CREATE EXTENSION error message |
| Previous Message | Tom Lane | 2021-11-29 22:03:22 | Re: improve CREATE EXTENSION error message |