From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
---|---|
To: | Mark Wong <markwkm(at)gmail(dot)com> |
Cc: | Bruce Momjian <bruce(at)momjian(dot)us>, Dave Page <dpage(at)pgadmin(dot)org>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: compile/install of git |
Date: | 2010-09-20 16:42:28 |
Message-ID: | 4C978EF4.5060403@dunslane.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 09/20/2010 12:24 PM, Mark Wong wrote:
> On Sat, Sep 18, 2010 at 7:59 AM, Bruce Momjian<bruce(at)momjian(dot)us> wrote:
>>
>> Well, I can run tests for folks before they apply a patch and "red" the
>> build farm. I can also research fixes easier because I am using the OS,
>> rather than running blind tests. I am just telling you what people told
>> me.
> I've been slowly trying to rebuild something that was in use at the
> OSDL to test patches. I just proofed something that I think works
> with the git repository:
>
> http://207.173.203.223:5000/patch/show/48
>
> If you click on the PASS or FAIL text, it will display the SHA1,
> author and commit message that the patch was applied to. Think this
> will be useful?
The issue has always been how much we want to ask people to trust code
that is not committed. My answer is "not at all." Reviewers and
committers will presumably eyeball the code before trying to compile/run
it, but any automated system of code testing for uncommitted code is way
too risky, IMNSHO.
cheers
andrew
From | Date | Subject | |
---|---|---|---|
Next Message | Simon Riggs | 2010-09-20 16:44:26 | Re: Do we need a ShmList implementation? |
Previous Message | Robert Haas | 2010-09-20 16:38:33 | Re: compile/install of git |