| From: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: elog during holding a spinlock is safe? |
| Date: | 2010-09-15 06:51:16 |
| Message-ID: | 4C906CE4.9010609@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 15/09/10 05:47, Tom Lane wrote:
> Fujii Masao<masao(dot)fujii(at)gmail(dot)com> writes:
>> In HEAD, OwnLatch can elog during holding the spinlock WalSnd->mutex.
>> This seems to be unsafe
>
> Even if it were safe, holding a spinlock through non-straight-line code
> is a complete violation of the spinlock coding rules re the length of
> time you're supposed to hold the lock. Heikki?
Yep, that's an oversight. I'll move the OwnLatch call after the spinlock
is released.
--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2010-09-15 07:02:25 | Re: patch: SQL/MED(FDW) DDL |
| Previous Message | Markus Wanner | 2010-09-15 06:48:38 | Re: bg worker: patch 1 of 6 - permanent process |