Re: ECPG dynamic cursor fix for UPDATE/DELETE ... WHERE CURRENT OF :curname

From: Boszormenyi Zoltan <zb(at)cybertec(dot)at>
To: Kevin Grittner <Kevin(dot)Grittner(at)wicourts(dot)gov>
Cc: Michael Meskes <meskes(at)postgresql(dot)org>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: ECPG dynamic cursor fix for UPDATE/DELETE ... WHERE CURRENT OF :curname
Date: 2010-08-03 17:29:45
Message-ID: 4C585209.1030300@cybertec.at
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Kevin Grittner írta:
> Boszormenyi Zoltan <zb(at)cybertec(dot)at> wrote:
>
>
>> attached is a patch that adds the missing feature
>>
>
>
>> I certainly feel that this should be applied to 9.0 as a bugfix.
>>
>
> Those two statements seem to contradict one another.

PostgreSQL 8.3 or so added WHERE CURRENT OF <curname> at the SQL level.

9.0 added ECPG's dynamic cursorname (a char variable carries the actual
cursor name)
but the WHERE CURRENT OF part was not converted, which was definitely an
oversight. Whether this is a "missing feature" or a "bugfix", it's only
a difference in
points of view. I think this patch belongs to 9.0.

> Is there some
> bug manifestation beyond an unimplemented feature this fixes?
> Without this, is there some regression going from 8.4 to 9.0?
>

I haven't looked at 8.4's regression tests but pgtypeslib/numeric.c in
8.4.4 has
the same problem, so the second patch (at least the numeric.c part) can be
applied there as well, maybe in even older branches.

Best regards,
Zoltán Böszörményi

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2010-08-03 17:46:06 Re: [COMMITTERS] pgsql: Add \conninfo command to psql, to show current connection info.
Previous Message Kevin Grittner 2010-08-03 17:11:27 Re: ECPG dynamic cursor fix for UPDATE/DELETE ... WHERE CURRENT OF :curname