Re: Preliminary review of Synchronous Replication patches

From: "Kevin Grittner" <Kevin(dot)Grittner(at)wicourts(dot)gov>
To: "Boszormenyi Zoltan" <zb(at)cybertec(dot)at>, "Fujii Masao" <masao(dot)fujii(at)gmail(dot)com>, "Yeb Havinga" <yebhavinga(at)gmail(dot)com>, "PostgreSQL-development Hackers" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Preliminary review of Synchronous Replication patches
Date: 2010-07-21 15:34:26
Message-ID: 4C46CD320200002500033A9C@gw.wicourts.gov
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Yeb Havinga <yebhavinga(at)gmail(dot)com> wrote:

> Kevin asked me to do a preliminary review on both synchronous
> replication patches.

Thanks for doing so.

BTW, Yeb has emailed me off-list that he has more specific notes on
both patches, but has run into high priority items on his "day job"
which will prevent him from posting those for another day or two.

> Since both patches overlap in functionality, applying one in core
> means not applying the other. Initially I set out to do a complete
> review of both patches and let the difficult choice of preferring
> one over the other to fellow reviewers. However, for the following
> reasons I believe that patch (A) should probably be withdrawn and
> the review effort continued on (B).

Unless there are objections, I will mark the patch by Zoltán
Böszörményi as Returned with Feedback in a couple days, and ask that
everyone interested in this feature focus on advancing the patch by
Fujii Masao. Given the scope and importance of this area, I think
we could benefit from another person or two signing on officially as
Reviewers.

-Kevin

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2010-07-21 15:49:51 Re: sql/med review - problems with patching
Previous Message David Christensen 2010-07-21 15:31:59 Re: Explicit psqlrc