Re: pgsql: Mention why one C file fails pgindent.

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Bruce Momjian <momjian(at)postgresql(dot)org>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Mention why one C file fails pgindent.
Date: 2010-07-06 21:34:03
Message-ID: 4C33A14B.4060103@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Bruce Momjian wrote:
> Log Message:
> -----------
> Mention why one C file fails pgindent.
>
> Modified Files:
> --------------
> pgsql/src/tools/pgindent:
> README (r1.41 -> r1.42)
> (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/tools/pgindent/README?r1=1.41&r2=1.42)
>
>

Why not add the file that breaks to
src/tools/pgindent/exclude_file_patterns? (And also maybe the file Tom
just fixed).

And ISTM we should have a list of typdefs for pgindent to ignore anyway.
Currently, the buildfarm ignores:

'date','interval','timestamp','ANY'

We should probably add 'DECIMAL' to that list.

But really, this list should probably be part of pgindent, not of the
typedef finding code.

cheers

andrew

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2010-07-06 21:37:31 pgsql: Add note that using PL/Python 2 and 3 in the same session will
Previous Message Robert Haas 2010-07-06 21:14:25 pgsql: Support setting the keepalive idle time on MacOS X.