Re: [PATCH] elimination of code duplication in DefineOpFamily()

From: Brent Dombrowski <brent(dot)dombrowski(at)gmail(dot)com>
To: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCH] elimination of code duplication in DefineOpFamily()
Date: 2010-06-17 01:31:22
Message-ID: 4C197AEA.3030108@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I have not been able to find any comments or discussion on this patch.

Contents and Purpose:
================
This patch removes duplicate code in opclasscmds.c. It removes the
duplicate code from DefineOpFamily by calling CreateOpFamily.

No new regression test or documentation are included with the patch.
Since it is not adding, removing, or changing any functionality, they
are most likely not necessary. The function call parameters remain the same.

Initial Run
========
The patch applied cleanly to HEAD. The regression tests pass both before
and after the patch.

Performance
=========
No changes in performance were observed. I do not have an appropriate
setup to properly test for performance impacts. Since this changes a
define function, I would not expect it to be frequently used.

Conclusion
========
The patch eliminates duplicate code as expected.

Brent Dombrowski

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2010-06-17 01:37:13 Re: InvalidXLogRecPtr in docs
Previous Message David E. Wheeler 2010-06-17 00:56:13 Re: hstore ==> and deprecate =>