Re: InvalidXLogRecPtr in docs

From: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Takahiro Itagaki <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: InvalidXLogRecPtr in docs
Date: 2010-06-10 07:00:46
Message-ID: 4C108D9E.2000502@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 10/06/10 05:56, Tom Lane wrote:
> Robert Haas<robertmhaas(at)gmail(dot)com> writes:
>> On Wed, Jun 9, 2010 at 9:46 PM, Takahiro Itagaki
>> <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp> wrote:
>>> I found a term "InvalidXLogRecPtr" in 9.0 docs.
>>> http://developer.postgresql.org/pgdocs/postgres/functions-admin.html#FUNCTIONS-RECOVERY-INFO-TABLE
>>> | ... then the return value will be InvalidXLogRecPtr (0/0).
>
>> Maybe we should be returning NULL instead of 0/0.
>
> +1 for using NULL instead of an artificially chosen value, for both of
> those functions.

Agreed, committed a patch to do that.

--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2010-06-10 07:07:13 Re: InvalidXLogRecPtr in docs
Previous Message Fujii Masao 2010-06-10 06:42:35 Re: InvalidXLogRecPtr in docs