From: | "Kevin Grittner" <Kevin(dot)Grittner(at)wicourts(dot)gov> |
---|---|
To: | "Andy Balholm" <andy(at)balholm(dot)com> |
Cc: | <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: dividing money by money |
Date: | 2010-06-01 15:09:38 |
Message-ID: | 4C04DC620200002500031C5A@gw.wicourts.gov |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-www |
Andy Balholm <andy(at)balholm(dot)com> wrote:
> I made my diff with src/tools/make_diff, as suggested in the
> Developer FAQ. But using git diff would be less hassle. Do the
> diffs from git diff work just as well?
I agree about the git diff being easier; however, those files are in
unified format and some committers prefer to read the context
format, so I'd recommend piping it through filterdiff
--format=context. Personally, although I submit patches in context
format, I keep the unified copy around because I find the method
names from git useful and I like to be able to view the patch
through kompare, which doesn't seem to like the context format as
well.
-Kevin
From | Date | Subject | |
---|---|---|---|
Next Message | Thom Brown | 2010-06-01 15:16:33 | VACUUM messages without newlines |
Previous Message | Bruce Momjian | 2010-06-01 15:09:06 | Re: Exposing the Xact commit order to the user |
From | Date | Subject | |
---|---|---|---|
Next Message | Alvaro Herrera | 2010-06-01 15:30:54 | Re: dividing money by money |
Previous Message | Stefan Kaltenbrunner | 2010-06-01 15:00:51 | Re: dividing money by money |