From: | Mike Fowler <mike(at)mlfowler(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Erik Rijkers <er(at)xs4all(dot)nl>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [PATCH] Add XMLEXISTS function from the SQL/XML standard |
Date: | 2010-05-26 10:10:17 |
Message-ID: | 4BFCF389.8000809@mlfowler.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Tom Lane wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>
>> On Tue, May 25, 2010 at 1:09 PM, Mike Fowler <mike(at)mlfowler(dot)com> wrote:
>>
>>>> We're unlikely to accept this patch if it changes the minimum version
>>>> of libxml2 required to compile PostgreSQL
>>>>
>>> Why? 2.6.27 is almost 4 years old.
>> At a minimum, I think it's fair to say that the burden is on you to
>> justify what it's worth bumping the version number.
>>
>
> Yes. Increasing the minimum required version of some library is a Big
> Deal, we don't do it on a whim. And we definitely don't do it just
> because it's old.
>
> regards, tom lane
>
>
OK, I consider myself suitably educated/chastised. I now understand why
a version bump is such a big deal. Your objections are all reasonable, I
suppose I'm just used to living on the bleeding edge of everything.
Consequently I have changed the code to produce the same result in a
different way without using the new function. I've down-graded my
version to 2.6.26 and it all compiles cleanly. Please find attached my
revised patch, and thanks all for your advise.
Regards,
--
Mike Fowler
Registered Linux user: 379787
Attachment | Content-Type | Size |
---|---|---|
xmlexists-3.patch | text/x-diff | 11.9 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Eisentraut | 2010-05-26 10:14:12 | Re: [PATCH] Add XMLEXISTS function from the SQL/XML standard (was: Add xpath_exists Function) |
Previous Message | Peter Eisentraut | 2010-05-26 10:01:43 | Re: Regression testing for psql |