Re: missing file in git repo

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Cc: Magnus Hagander <magnus(at)hagander(dot)net>, Aidan Van Dyk <aidan(at)highrise(dot)ca>, Kevin Grittner <Kevin(dot)Grittner(at)wicourts(dot)gov>, Alexey Klyukin <alexk(at)commandprompt(dot)com>, Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, "cedric(dot)villemain(dot)debian" <cedric(dot)villemain(dot)debian(at)gmail(dot)com>, Stefan Kaltenbrunner <stefan(at)kaltenbrunner(dot)cc>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: missing file in git repo
Date: 2010-05-03 19:46:32
Message-ID: 4BDF2818.2020708@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Alvaro Herrera wrote:
> Andrew Dunstan escribió:
>
>
>> I pulled together a quick hack, and here is what I get from my
>> mirrors. I'm not sure why we get those diffs - it's a bit odd,
>> although fairly insignificant.
>>
>
> Well, it's a $Log$ CVS keyword -- it's not surprising that it's failing
> to provide exactly identical output, because it's a fairly strange
> keyword. Note that it's the only $Log$ in the whole tree, and the
> reason you don't see it in 8.1 and beyond is because that contrib module
> was removed.
>
> Moreover, note that this particular file got imported from another CVS
> repo that had already expanded this Log keyword. It's not really
> surprising that moving it to git fails to provide a verbatim copy.
>
> If I were worried about this, I'd edit the file in all back branches and
> remove the changelog ... or maybe de-magicalize it by removing the first
> line.
>

Thanks for this analysis.

Based in this, I'm going to exclude these two files from the test. There
are other instances I can see of $Log$, but it looks like they are not
affecting us.

cheers

andrew

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2010-05-03 19:54:00 Re: max_standby_delay considered harmful
Previous Message Greg Sabino Mullane 2010-05-03 19:41:01 Re: max_standby_delay considered harmful