| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | vignesh C <vignesh21(at)gmail(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, "Shinoda, Noriyoshi (SXD Japan FSIP)" <noriyoshi(dot)shinoda(at)hpe(dot)com>, Shubham Khanna <khannashubham1197(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Rajendra Kumar Dangwal <dangwalrajendra888(at)gmail(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "euler(at)eulerto(dot)com" <euler(at)eulerto(dot)com> |
| Subject: | Re: Pgoutput not capturing the generated columns |
| Date: | 2025-01-23 12:44:45 |
| Message-ID: | 4BDA1D83-3C53-4B2F-88C3-2D676CA43248@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 23 Jan 2025, at 13:19, vignesh C <vignesh21(at)gmail(dot)com> wrote:
> When dumping from Postgres <=PG17 servers, the query generated for
> pubgencols_type incorrectly included the macro name instead of the
> macro value. This resulted in dump failures. This commit fixes the
> issue by correctly specifying the macro value in the query. The
> attached patch has the changes for the same.
I was just looking at the Xversion test failure on crake (which has the log
entry below) when I saw your email.
pg_dump: error: query failed: ERROR: column "publish_gencols_none" does not exist
LINE 1: ...elete, false AS pubtruncate, false AS pubviaroot, PUBLISH_GE...
^
pg_dump: detail: Query was: SELECT p.tableoid, p.oid, p.pubname, p.pubowner, p.puballtables, p.pubinsert, p.pubupdate, p.pubdelete, false AS pubtruncate, false AS pubviaroot, PUBLISH_GENCOLS_NONE AS pubgencols_type FROM pg_publication p
pg_dumpall: error: pg_dump failed on database "template1", exiting
Your patch seems like a reasonable fix.
--
Daniel Gustafsson
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Yura Sokolov | 2025-01-23 12:50:13 | Re: Increase NUM_XLOGINSERT_LOCKS |
| Previous Message | Zhijie Hou (Fujitsu) | 2025-01-23 12:24:50 | RE: create subscription with (origin = none, copy_data = on) |