From: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Re: [COMMITTERS] pgsql: Make CheckRequiredParameterValues() depend upon correct |
Date: | 2010-04-28 07:43:06 |
Message-ID: | 4BD7E70A.6000908@enterprisedb.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
Tom Lane wrote:
> Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
>> Hmm, AFAICS the problem with controldata is that it uses postgres_fe.h
>> instead of postgres.h. It's a bit of a stretch to use the latter, but
>> maybe that's a better solution? After all, it *is* poking into the
>> backend internals.
>
> I seem to recall that Solaris had problems with that due to dtrace
> support or something? However, we are doing it in pg_resetxlog,
> so I suppose it's ok for pg_controldata as well.
Ok, did that. Here's an updated patch:
* made incorrect combinations of wal_mode and
archive_mode/max_wal_senders throw an ERROR instead of WARNING
* renamed wal_mode to wal_level
* reworded the documentation changes a bit
This doesn't contain any changes to pg_start_backup() yet, that's a
separate issue and still under discussion.
At commit, should I bump catversion, or PG_CONTROL_VERSION, or both? The
patch replaces the unlogged-operation WAL record with a record
containing current parameter values, and it changes pg_control. I'm
guessing both.
--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com
Attachment | Content-Type | Size |
---|---|---|
wal_mode-4.patch | text/x-diff | 37.3 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Simon Riggs | 2010-04-28 08:00:04 | Re: Re: [COMMITTERS] pgsql: Make CheckRequiredParameterValues() depend upon correct |
Previous Message | Heikki Linnakangas | 2010-04-28 07:34:11 | pgsql: Add recovery.conf parameters to the documentation index, per |
From | Date | Subject | |
---|---|---|---|
Next Message | Heikki Linnakangas | 2010-04-28 07:47:02 | Re: Error handling for ShmemInitStruct and ShmemInitHash |
Previous Message | Takahiro Itagaki | 2010-04-28 04:02:16 | Re: Add column if not exists (CINE) |