| From: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Re: [COMMITTERS] pgsql: Make CheckRequiredParameterValues() depend upon correct |
| Date: | 2010-04-27 17:18:28 |
| Message-ID: | 4BD71C64.5090509@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Tom Lane wrote:
> Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> writes:
>> Ok, here's a patch that includes the changes to add new wal_mode GUC
>> (http://archives.postgresql.org/message-id/4BD581A6.60602@enterprisedb.com)
>
> I haven't read this in any detail, but why does it add inclusion of
> pg_control.h to xlog.h? I don't see any reason for that in the actual
> changes in xlog.h.
I put the enum for wal_mode to pg_control.h, so that it's available to
pg_controlinfo.c without #including xlog.h there. The
XLogArchivingActive() macro in xlog.h needs the enum values:
#define XLogArchivingActive() (XLogArchiveMode && wal_mode >=
WAL_MODE_ARCHIVE
I'm all ears for better suggestions, I didn't like that much either.
--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2010-04-27 18:16:18 | Re: Re: [COMMITTERS] pgsql: Make CheckRequiredParameterValues() depend upon correct |
| Previous Message | Tom Lane | 2010-04-27 15:42:58 | Re: Re: [COMMITTERS] pgsql: Make CheckRequiredParameterValues() depend upon correct |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2010-04-27 17:52:50 | Re: testing HS/SR - 1 vs 2 performance |
| Previous Message | Heikki Linnakangas | 2010-04-27 17:14:01 | Re: Wierd quirk of HS/SR, probably not fixable |