Re: trying to write a bit of logic as one query, can't seem to do it under 2

From: Glen Parker <glenebob(at)nwlink(dot)com>
To: pgsql-general(at)postgresql(dot)org
Cc: Jonathan Vanasco <postgres(at)2xlp(dot)com>
Subject: Re: trying to write a bit of logic as one query, can't seem to do it under 2
Date: 2010-04-22 00:51:21
Message-ID: 4BCF9D89.2050309@nwlink.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general

Tom Lane wrote:
> Jonathan Vanasco <postgres(at)2xlp(dot)com> writes:
>> I'm trying to write a bit of logic as 1 query, but I can't seem to do
>> it under 2 queries.
>
> Uh, why can't you just push that CASE expression into the sub-select?
>
> <QUERY SNIPPED>
>
> You might have to qualify qty_requested here to make sure it comes from
> cart_item, if there's a column of the same name in stock.
>
> BTW, I'd suggest using GREATEST() instead of the CASE, but that's
> just a minor improvement.

Like so?

UPDATE
cart_item
SET
qty_requested_available = least(cart_item.qty_requested,
stock.qty_available)
FROM
stock
WHERE
cart_item.stock_id = stock.stock_id AND
qty_requested_available <> least(cart_item.qty_requested,
stock.qty_available);

Also note the qualifier that prevents the query from updating every
cart_item row whether it needs it or not.

-Glen

In response to

Responses

Browse pgsql-general by date

  From Date Subject
Next Message Jonathan Vanasco 2010-04-22 01:21:57 Re: trying to write a bit of logic as one query, can't seem to do it under 2
Previous Message Craig Ringer 2010-04-22 00:47:21 Re: installation on vista