Re: build error: strlcat/strlcpy used from heimdal libroken.so

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Dear Bruce,

On 15.04.2010 03:59, Bruce Momjian wrote:
> I haven't seen anyone reply to this report,

Probably because Craig Ringer forwarded it to the -hackers list with cc
to me personally, but not to these lists. For that thread see
http://thread.gmane.org/gmane.comp.db.postgresql.devel.general/139424

> which might mean we are
> waiting for Gentoo to be fixed. Gentoo is notoriously dynamic and it is
> hard for us to adjust based on their changes in every case, which I
> guess explains why 8.4.X has not been fixed either.

As I see it, Gentoo is one of the best ways to expose bugs in the build
system of any package, due to the high number of from-source builds
using various setups that Gentoo users perform. So I'd not say you'd be
adjusting pgsql to Gentoo, but you'd be fixing a bug in your build
system which Gentoo users have found and analyzed, but which might as
well hit other people building from source on their own.

So yes, Gentoo could address this at the distribution level, and as I
wrote on the Gentoo bug report, I hope they will do so soon. But the bug
is in the pgsql build system (and a bit in heimdal), so if you were to
apply one of the proposed fixes upstream, at least for future releases,
then more users could benefit.

> Martin von Gagern wrote:
>> Another alternative might be choosing behaviour based on the detection
>> of suitable function declarations, i.e. HAVE_DECL_STRLCAT instead of
>> HAVE_STRLCAT. Or you might try enabling the -Wl,--as-needed flag before
>> detecting these library functions, to ensure the same behaviour at
>> configure time and at build time. In both cases you might whish to
>> rename those symbols in case you use your own implementation, just to
>> make sure the linker knows which one to choose.

I've thought of one more alternative: Move the detection of gssapi and
krb5 libraries to a place after strcat/strcpy have been detected.

Greetings,
Martin
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.14 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkvGtE0ACgkQRhp6o4m9dFvLqwCgmszpmy54y7oTxxNT6ssmTps+
J5IAoI9ENyPBVtZVsgSOfGPA1I3s/Wbl
=jpbU
-----END PGP SIGNATURE-----