Re: Hot Standby: Startup at shutdown checkpoint

From: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
To: Simon Riggs <simon(at)2ndQuadrant(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>
Subject: Re: Hot Standby: Startup at shutdown checkpoint
Date: 2010-04-13 14:18:54
Message-ID: 4BC47D4E.1020704@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Simon Riggs wrote:
> On Thu, 2010-04-08 at 19:02 +0300, Heikki Linnakangas wrote:
>> Simon Riggs wrote:
>>> OK, that seems better. I'm happy with that instead.
>>>
>>> Have you tested this? Is it ready to commit?
>> Only very briefly. I think the code is ready, but please review and test
>> to see I didn't miss anything.
>
> I'm going to need you to commit this. I'm on holiday now until 14 April,
> so its not going to get a retest before then otherwise; its not smart to
> commit and then go on holiday, IIRC.

:-)

> I've reviewed your changes and they look correct to me; the main chunk
> of code is mine and that was tested by me.

Ok, committed after fixing an obsoleted comment & other small
editorialization.

--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jaime Casanova 2010-04-13 15:41:08 hash indexes and HS was:(Re: [HACKERS] testing hot standby)
Previous Message Fujii Masao 2010-04-13 14:16:27 Re: pending patch: Re: HS/SR and smart shutdown