Report roles in pg_upgrade pg_ prefix check

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Report roles in pg_upgrade pg_ prefix check
Date: 2022-11-24 11:31:09
Message-ID: 4BB2735C-C347-4CF7-AFB1-8573BE930066@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Looking at a recent pg_upgrade thread I happened to notice that the check for
roles with a pg_ prefix only reports the error, not the roles it found. Other
similar checks where the user is expected to alter the old cluster typically
reports the found objects in a textfile. The attached adds reporting to make
that class of checks consistent (the check for prepared transactions which also
isn't reporting is different IMO as it doesn't expect ALTER commands).

As this check is only executed against the old cluster the patch removes the
check when printing the error.

--
Daniel Gustafsson https://vmware.com/

Attachment Content-Type Size
v1-0001-Report-incompatible-roles-in-pg_upgrade-checking.patch application/octet-stream 2.2 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Sergey Shinderuk 2022-11-24 11:52:30 Re: Bug in row_number() optimization
Previous Message Etsuro Fujita 2022-11-24 11:19:10 Re: postgres_fdw: batch inserts vs. before row triggers