Re: testing cvs HEAD - HS/SR - xlog timeline 0 pg_xlogfile_name_offset

Fujii Masao wrote:
> On Thu, Feb 25, 2010 at 9:31 AM, Erik Rijkers <er(at)xs4all(dot)nl> wrote:
>> On Wed, February 24, 2010 20:40, Erik Rijkers wrote:
>>>
>>> pg_last_xlog_receive_location | pg_xlogfile_name_offset
>>> -------------------------------+-----------------------------------
>>> E2/C012AD90 | (00000000000000E2000000C0,1224080)
>>> (1 row)
>>>
>>> These zero-timeline filenames look suspicious, no?
>> Sorry, I've only now noticed that this issue is already on the v9.0 TODO for Streaming Replication:
>>
>> "pg_xlogfile_name(pg_last_xlog_receive/replay_location()) might report the wrong name. Because a
>> backend cannot know the actual timeline which is related to the location.
>> "
>>
>> http://archives.postgresql.org/message-id/3f0b79eb1001190135vd9f62f1sa7868abc1ea61d12@mail.gmail.com
>>
>> so, nevermind..
>
> Yeah, since I thought that the current behavior that you reported
> would annoy many users, I added it to the TODO list.

Yeah, returning a filename with TLI 0 sure doesn't seem right.

A quick fix would be to just throw an error if you try to use
pg_xlog_filename() during hot standby. But there seems to be good
reasons to call pg_xlog_filename() during hot standby, given that both
of you ran into the same issue. What exactly were you trying to achieve
with it?

--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com