| From: | Stefan Kaltenbrunner <stefan(at)kaltenbrunner(dot)cc> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, Jeremy Kerr <jk(at)ozlabs(dot)org>, Stephen Frost <sfrost(at)snowman(dot)net>, Dimitri Fontaine <dfontaine(at)hi-media(dot)com>, pgsql-hackers(at)postgresql(dot)org, Gurjeet Singh <singh(dot)gurjeet(at)gmail(dot)com> |
| Subject: | Re: [PATCH] backend: compare word-at-a-time in bcTruelen |
| Date: | 2010-02-23 18:42:34 |
| Message-ID: | 4B84219A.9000602@kaltenbrunner.cc |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Tom Lane wrote:
> Stefan Kaltenbrunner <stefan(at)kaltenbrunner(dot)cc> writes:
>> hmm I tend to disagree, this patch was specifically done to address a
>> hotspot I noticed under a given workload and it helped a lot for that
>> workload(like getting 6000qps more is pretty neat imho).
>> While people might not use fixed width chars that often(which especially
>> for migrated database is imho not true) it is an issue that can be seen
>> with a rather popular database related benchmarking tool so we should
>> not really dismiss it easily.
>
> Nobody suggested dismissing it. The point was that it hasn't been
> tested adequately to justify applying it now.
not sure what testing people want to get done though (there are a fair
amount of results and profiles in the thread)?
Stefan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2010-02-23 18:47:57 | Re: [PATCH] 8.5 TODO: Add comments to output indicating version of pg_dump and of the database server |
| Previous Message | Tom Lane | 2010-02-23 18:39:56 | Re: [PATCH] backend: compare word-at-a-time in bcTruelen |