Re: PATCH(WIP): Printing Support And Save GQB/Explain as an image

Le 07/12/2009 23:12, Guillaume Lelarge a écrit :
> Le lundi 7 décembre 2009 à 22:40:54, Guillaume Lelarge a écrit :
>> Ashesh Vashi a écrit :
>>> Hi Guillaume,
>>>
>>>
>>> My fault, sorry. I'll work on your patch tonight.
>>>
>>>
>>> I understand.
>>> Here, everybody have some work with different priorities.
>>
>> I first tried on Linux and was unable to trigger the issues you're
>> talking about. I then tried on Mac OS X, no success either. I finally
>> tried on Windows, hoping that the Microsoft IDE will help me. Alas, all
>> I got were these error messages:
>>
>> 1>frmQuery.obj : error LNK2019: unresolved external symbol "public: void
>> __thiscall ExplainCanvas::PrintPreview(void)"
>> (?PrintPreview(at)ExplainCanvas@@QAEXXZ) referenced in function "private:
>> void __thiscall frmQuery::OnPrintPreview(class wxCommandEvent &)"
>> (?OnPrintPreview(at)frmQuery@@AAEXAAVwxCommandEvent@@@Z)
>> 1>frmQuery.obj : error LNK2019: unresolved external symbol "public: void
>> __thiscall gqbView::PrintPreview(void)" (?PrintPreview(at)gqbView@@QAEXXZ)
>> referenced in function "private: void __thiscall
>> frmQuery::OnPrintPreview(class wxCommandEvent &)"
>> (?OnPrintPreview(at)frmQuery@@AAEXAAVwxCommandEvent@@@Z)
>> 1>frmQuery.obj : error LNK2019: unresolved external symbol "public: void
>> __thiscall ctlSQLBox::PrintPreview(void)"
>> (?PrintPreview(at)ctlSQLBox@@QAEXXZ) referenced in function "private: void
>> __thiscall frmQuery::OnPrintPreview(class wxCommandEvent &)"
>> (?OnPrintPreview(at)frmQuery@@AAEXAAVwxCommandEvent@@@Z)
>> 1>frmQuery.obj : error LNK2019: unresolved external symbol "public: void
>> __thiscall ExplainCanvas::Print(void)" (?Print(at)ExplainCanvas@@QAEXXZ)
>> referenced in function "private: void __thiscall frmQuery::OnPrint(class
>> wxCommandEvent &)" (?OnPrint(at)frmQuery@@AAEXAAVwxCommandEvent@@@Z)
>> 1>frmQuery.obj : error LNK2019: unresolved external symbol "public: void
>> __thiscall gqbView::Print(void)" (?Print(at)gqbView@@QAEXXZ) referenced in
>> function "private: void __thiscall frmQuery::OnPrint(class
>> wxCommandEvent &)" (?OnPrint(at)frmQuery@@AAEXAAVwxCommandEvent@@@Z)
>> 1>frmQuery.obj : error LNK2019: unresolved external symbol "public: void
>> __thiscall ctlSQLBox::Print(void)" (?Print(at)ctlSQLBox@@QAEXXZ) referenced
>> in function "private: void __thiscall frmQuery::OnPrint(class
>> wxCommandEvent &)" (?OnPrint(at)frmQuery@@AAEXAAVwxCommandEvent@@@Z)
>>
>> I checked everything I could think of. But to no avail. I must be tired,
>> I really don't understand what's happening here. The linker can't find
>> some functions, but they are there. The only possibility I see is that I
>> don't have printing support on Windows, but I don't think so.
>>
>> Any ideas on my issues?
>>
>
> BTW, I tried to print a few explain, and they looked great. I'm gonna read
> your patch now.
>
>

Here is an updated patch. I fixed the two issues I noticed (menu always
enabled, and the menus' UI). I'll try to work more on it, but frankly
I'm not that good with drawing programs.

--
Guillaume.
http://www.postgresqlfr.org
http://dalibo.com