Re: Failed assertion during recovery of partial WAL file

From: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: Martin Pihlak <martin(dot)pihlak(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Failed assertion during recovery of partial WAL file
Date: 2010-02-10 08:26:07
Message-ID: 4B726D9F.2050304@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Fujii Masao wrote:
> This assertion failure derives from the recent refactoring of ReadRecord().
> Which changed the startup process so as to re-fetch the last applied WAL
> record at the end of recovery from the buffer instead of the WAL file if it's
> stored in the buffer. In this case, the last applied WAL file remains closed.
> So readFile (which ought to have been the file descriptor of that WAL file)
> might be -1 in exitArchiveRecovery().
>
> In the now, that assertion is obsolete. So I attached the patch that removes
> the assert() from exitArchiveRecovery().

Committed.

--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Kurt Harriman 2010-02-10 08:43:18 Re: Patch: Remove gcc dependency in definition of inline functions
Previous Message Heikki Linnakangas 2010-02-10 07:32:48 Re: [COMMITTERS] pgsql: Make standby server continuously retry restoring the next WAL