| From: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgreSQL(dot)org |
| Subject: | Re: Order of operations in lazy_vacuum_rel |
| Date: | 2010-02-08 20:01:05 |
| Message-ID: | 4B706D81.7010600@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Alvaro Herrera wrote:
> Tom Lane wrote:
>> The point would be to not disable interrupts till after doing the FSM
>> vacuuming. Ignoring CANCEL for longer than we must is bad.
>
> Oh, I see. I guess the answer is that it depends on what happens if you
> interrupt after vacuuming the FSM. I have no idea what that is supposed
> to accomplish so I'm of no help here. FreeSpaceMapVacuum says it's
> about fixing inconsistencies in the FSM, so I'm guessing that it's not
> critical.
Yeah, interrupting FreeSpaceMapVacuum (or right after it) is harmless.
> FWIW I notice that RelationTruncate contains an outdated comment at the
> top about the 'fsm' function argument which is nowadays no longer an
> argument.
Thanks, fixed.
--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2010-02-08 20:05:17 | Re: [CFReview] Red-Black Tree |
| Previous Message | Florian Weimer | 2010-02-08 19:50:37 | Re: Confusion over Python drivers |