Re: NaN/Inf fix for ECPG Re: out-of-scope cursor errors

From: Boszormenyi Zoltan <zb(at)cybertec(dot)at>
To: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Cc: Michael Meskes <meskes(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: NaN/Inf fix for ECPG Re: out-of-scope cursor errors
Date: 2010-02-03 09:59:57
Message-ID: 4B69491D.8090508@cybertec.at
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Michael Meskes írta:
> On Tue, Feb 02, 2010 at 03:34:24PM +0100, Boszormenyi Zoltan wrote:
>
>> Here's the new patch with the updated regression test.
>>
>
> Committed. Thanks a lot.
>
> Michael
>

Tom Lane committed a fix for Windows, there was a missing
#include <float.h>
in execute.c, but there is another problem on Windows, which
I can't fix since I don't have a Windows build system.
The linker also complains about missing _isnan(). Can someone help?
The equivalent of "-lm" is needed for the cl linker command.

Also, another oversight needs fixing on my part, for which
the patch is atttached. The INSERT statement in nan_test.pgc
contains platform dependent strings, "inf" instead of "infinity".

Best regards,
Zoltán Böszörményi

--
Bible has answers for everything. Proof:
"But let your communication be, Yea, yea; Nay, nay: for whatsoever is more
than these cometh of evil." (Matthew 5:37) - basics of digital technology.
"May your kingdom come" - superficial description of plate tectonics

----------------------------------
Zoltán Böszörményi
Cybertec Schönig & Schönig GmbH
http://www.postgresql.at/

Attachment Content-Type Size
pg85-ecpg-fix-nan-inf-8-ctxdiff.patch text/x-patch 3.4 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2010-02-03 10:03:00 Re: [COMMITTERS] pgsql: Write a WAL record whenever we perform an operation without
Previous Message Simon Riggs 2010-02-03 09:52:11 Re: Hot Standby: Relation-specific deferred conflict resolution