Re: [PATCH] Provide rowcount for utility SELECTs

Robert Haas írta:
> 2010/1/12 Boszormenyi Zoltan <zb(at)cybertec(dot)at>:
>
>> Tom Lane írta:
>>
>>> Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
>>>
>>>
>>>> But it would be broken in very obvious ways, no? It's not like it would
>>>> be silently broken and thus escape testing ...
>>>>
>>>>
>>> Well, if we wanted to adopt that approach, we should add the count to
>>> *all* SELECT tags not just a small subset. As the patch stands it
>>> seems entirely possible that a breakage would escape immediate notice.
>>>
>>>
>> Can you give me an example that would return
>> plain "SELECT" after my new patch? I added
>> one more change to the patch, is it enough to return
>> "SELECT N" in every case now?
>>
>
> I just tested this, so I can say definitely: no. I hacked psql with
> the attached patch, and if you just do a plain old SELECT * FROM
> table, you get back only SELECT, not SELECT N.
>
> ...Robert
>

Thanks for testing it, with the attached patch your test case also
returns SELECT N.

Best regards,
Zoltán Böszörményi

--
Bible has answers for everything. Proof:
"But let your communication be, Yea, yea; Nay, nay: for whatsoever is more
than these cometh of evil." (Matthew 5:37) - basics of digital technology.
"May your kingdom come" - superficial description of plate tectonics

----------------------------------
Zoltán Böszörményi
Cybertec Schönig & Schönig GmbH
http://www.postgresql.at/