Re: testing cvs HEAD - HS/SR - missing file

From: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: Erik Rijkers <er(at)xs4all(dot)nl>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: testing cvs HEAD - HS/SR - missing file
Date: 2010-01-27 11:37:43
Message-ID: 4B602587.5070703@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Fujii Masao wrote:
> On Wed, Jan 27, 2010 at 7:05 PM, Heikki Linnakangas
> <heikki(dot)linnakangas(at)enterprisedb(dot)com> wrote:
>> Before that, endptr is advanced using XLByteAdvance() macro, which does
>> handle xlogid boundaries. Is XLByteAdvance() broken?
>
> No. The cause of the bug is that endptr might be set to the SendRqstPtr
> that has crossed a xlogid boundary in the following code.
>
>> /* if we went beyond SendRqstPtr, back off */
>> if (XLByteLT(SendRqstPtr, endptr))
>> endptr = SendRqstPtr;

But SendRqstPtr comes from LogwrtResult.Write, surely that's correct, no?

--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2010-01-27 13:11:45 Re: testing cvs HEAD - HS/SR - missing file
Previous Message Magnus Hagander 2010-01-27 11:36:15 Re: Patch: psql \whoami option