Re: Patches

Le 23/01/2010 01:25, Guillaume Lelarge a écrit :
> Le 22/01/2010 09:42, Dave Page a écrit :
>> On Thu, Jan 21, 2010 at 9:46 PM, Guillaume Lelarge
>> <guillaume(at)lelarge(dot)info> wrote:
>>> Hi,
>>>
>>> I intend to work next on ticket 99 (Default ACLs). I'll need to change
>>> the role dialog that my previous patch already changed. Actually, I have
>>> quite some patches in the pipe. git makes it so easy to work on multiple
>>> patches, it is just marvellous. So I'll have to apply some of my patches
>>> to the SVN if I want to continue to work without too much fuss. At
>>> least, I'll need to commit the last one (ticket 102) ASAP.
>>
>> Yeah, you're really pumping them out at the moment :-). I'm afraid to
>> say that once again I've got *really* busy - this time putting
>> together a new build server for the 9.0 installers, which is somewhat
>> more complex than one might expect (new versions of the 4 base OSs,
>> each with their own quirks etc), build environments to setup for 30+
>> bits of software on each platform...
>>
>
> No problem. I'll check each of my patches on Windows and Mac OS X
> tomorrow, and apply the good one.
>
>> I'm happy that pgAdmin is getting such attention from such capable
>> hands for this release :-)
>>
>
> Thanks :)
>
> I'm not sure I share your opinion. I hope I'm not adding too many bugs..
>

Yesterday (and really early today :) ), I commited some of my patches. I
checked them on Windows, fixed a few bugs on them before commiting.

The two patches that didn't make it are ticket 102 (because of a refresh
bug for the users node and the databases node) and ticket 117 (the
EXPLAIN one). The latter because I had some comments from Magnus and
Euler, that I should work on. Moreover, Robert Haas wants to add some
more details in EXPLAIN (for hash buckets). I'll probably wait a bit to
see if he commits his stuff. Anyways, I'll first work on Magnus's and
Euler's comments, and then work on others patches next week.

--
Guillaume.
http://www.postgresqlfr.org
http://dalibo.com