From: | Greg Smith <greg(at)2ndquadrant(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Bernd Helmle <mailings(at)oopsware(dot)de>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Table size does not include toast size |
Date: | 2010-01-19 04:17:16 |
Message-ID: | 4B55324C.7050900@2ndquadrant.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Tom Lane wrote:
> I'm inclined to think that table vs. index is the right level of
> abstraction for these functions, and that breaking it down further than
> that isn't all that helpful. We have the bottom-level information
> (per-fork relation size) available for those who really want the
> details.
>
Fair enough; this certainly knocks off all the important stuff already,
just wanted final sanity check opinion. This one is ready for a
committer to look at now. My test case seems to work fine with a
moderately complex set of things to navigate. The main think I'm not
familiar enough with to have looked at deeply is exactly how the FSM and
toast computations are done, to check if there's any corner cases in how
it navigates forks and such that aren't considered.
--
Greg Smith 2ndQuadrant Baltimore, MD
PostgreSQL Training, Services and Support
greg(at)2ndQuadrant(dot)com www.2ndQuadrant.com
From | Date | Subject | |
---|---|---|---|
Next Message | Takahiro Itagaki | 2010-01-19 05:23:02 | Re: Fix auto-prepare #2 |
Previous Message | Kurt Harriman | 2010-01-19 03:40:49 | Re: Patch: Remove gcc dependency in definition of inline functions |