Re: test/example does not support win32.

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Hiroshi Saito <z-saito(at)guitar(dot)ocn(dot)ne(dot)jp>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Bruce Momjian <bruce(at)momjian(dot)us>
Subject: Re: test/example does not support win32.
Date: 2009-12-30 16:05:36
Message-ID: 4B3B7A50.4090905@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hiroshi Saito wrote:
> Hi Andrew-san.
>
> Although this is a standard in windows.
>
> *** testlibpq2.c.orig Wed Dec 30 13:19:03 2009
> --- testlibpq2.c Thu Dec 31 00:52:52 2009
> ***************
> *** 24,34 ****
> --- 24,39 ----
> *
> * INSERT INTO TBL1 VALUES (10);
> */
> +
> + #ifdef WIN32
> + #include <windows.h>
> + #endif
> #include <stdio.h>
> #include <stdlib.h>
> #include <string.h>
> #include <errno.h>
> #include <sys/time.h>
> + #include <sys/types.h>
> #include "libpq-fe.h"
>
> static void
>
> Does this become the standard which you consider?
> or #IFDEF Isn't it allowed?
>
>
I certainly think we can use ifdefs. This addition seems OK to me at
first glance. Does it solve the problem you encountered?

cheers

andrew

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2009-12-30 16:09:30 Re: test/example does not support win32.
Previous Message Kevin Grittner 2009-12-30 15:59:25 Re: Thoughts on statistics for continuously advancing columns