| From: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
|---|---|
| To: | Martin Pihlak <martin(dot)pihlak(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Subject: | Re: fdw validation function vs zero catalog id |
| Date: | 2009-12-23 12:24:42 |
| Message-ID: | 4B320C0A.5090501@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Martin Pihlak wrote:
> I wrote:
>> The validator is run for the generic options specified to CREATE/ALTER FDW,
>> SERVER and USER MAPPING (+ possible future SQL/MED objects). In this case the
>> catalog is always known. Also we can assume that the catalog is known, if a user
>> runs the validator directly. So yes, AFAICS there is no case for the "or zero".
>
> Updated patch attached. This now also removes the "or zero" note from
> the documentation and modifies postgresql_fdw_validator() to assume that
> a valid catalog oid is always passed.
Committed. I don't foresee any scenario either where we wouldn't know
the catalog ID.
--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2009-12-23 12:36:14 | win32env.c bug with no msvcrt |
| Previous Message | Greg Stark | 2009-12-23 11:37:44 | Re: creating index names automatically? |