Re: new CommitFest states

From: Greg Smith <greg(at)2ndquadrant(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Kevin Grittner <Kevin(dot)Grittner(at)wicourts(dot)gov>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: new CommitFest states
Date: 2009-12-14 17:38:36
Message-ID: 4B26781C.3040701@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Robert Haas wrote:
> I don't think there should be a transition from Returned with Feedback
> back to Waiting for review. Granted we might allow that occasionally
> as an exceptional case, but normally Returned with Feedback is a final
> state.
>
I did throw some disclaimers in the notes about this particular subject
at the bottom of the table. The main reason I put that in there is that
sometimes a reviewer or even the CF manager (I did this myself once this
time) will mark something "Returned with feedback", thinking there's no
way the issues pointed out can be addressed right now. And then, a day
or two later, in comes a patch that does just that; surprise! Since it
seems to happen anyway, and I'd prefer not to get in the position where
people are screaming "you threw me out with 'RWF' unfairly", I thought
it was better to accept that possibility so long as the whole thing is
tightly bounded as far as how much time the author has to do it.

> (Also, Waiting for review is actually the wrong name for the state
> it's trying to talk about.)
>
Uh, what are you talking about here?

--
Greg Smith 2ndQuadrant Baltimore, MD
PostgreSQL Training, Services and Support
greg(at)2ndQuadrant(dot)com www.2ndQuadrant.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2009-12-14 17:42:58 Re: new CommitFest states
Previous Message Robert Haas 2009-12-14 17:11:09 Re: new CommitFest states