Re: thread safety on clients

Bruce Momjian wrote:
> Peter Eisentraut wrote:
>
>>> if i remove the -j option then it runs without a problem
>>>
>> Possibly related to the incomplete removal of the enable-thread-safety
>> option that I just posted about.
>>
>
> I thought about that but I can't figure out how that would affect
> pgbench.
>
The "-j" option is the recent addition to pgbench that causes it to
launch multiple client threads when enabled, each handling a subset of
the transactions. There's blocks of codes in pgbench.c now that depend
on having sane values for thread safety in libpq. That it may be
detecting the wrong thing and operating in an unsafe way after the
recent change is what Peter's suggesting. This is good, actually,
because I don't think we had many client-side thread-safety tests
floating around to catch problems in this area before.

--
Greg Smith 2ndQuadrant Baltimore, MD
PostgreSQL Training, Services and Support
greg(at)2ndQuadrant(dot)com www.2ndQuadrant.com