Re: Patch committers

From: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: Bruce Momjian <bruce(at)momjian(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Craig Ringer <craig(at)postnewspapers(dot)com(dot)au>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Patch committers
Date: 2009-11-16 09:20:37
Message-ID: 4B011965.7090807@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Magnus Hagander wrote:
> On Mon, Nov 16, 2009 at 02:08, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
>> Magnus Hagander wrote:
>>> On Sat, Nov 14, 2009 at 13:35, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>>>> On Sat, Nov 14, 2009 at 4:11 AM, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
>>>>> How about we add specific feature(s) about tihs to the commitfest
>>>>> management tool? Like the possibility to directly link a git
>>>>> repo/branch with the patch?
>>>> So two fields, one for the repo URL and one for the branch name?
>>> Yeah, I think that's it. It might actually be interesting to pull the
>>> latest version date and make a note in the cf management stuff
>>> automagically in case there the git repo has a more updated version
>>> than the one that was submitted. I think that could be quite useful -
>>> shouldn't be too hard to do, I think. Probably just a cron job that
>>> updates a third col in the db?
>> Can you get git to dynamically generate a tree diff via a URL? That
>> would be nice. Extra points for a context diff. ;-)
>
> yes, easily. Just pass it the commit id. And unlike cvs, there is one
> diff for the patch, not one for every file ;)
> For example:
> http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=d3359020ef7e0fba02ac552d88ede0c3ce5128cc
>
> turning it into context-diff style will require patching gitweb
> though, it doesn't do that by default.

Any idea how the get the equivalent of "git diff <branch A> <branch B>"
through the web interface?

--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Itagaki Takahiro 2009-11-16 09:29:42 Re: New VACUUM FULL
Previous Message Mark Pith 2009-11-16 09:18:49 Academic research on programmers' motivation