Re: some dead code in functioncmds.c

From: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
To: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: some dead code in functioncmds.c
Date: 2009-10-30 13:50:27
Message-ID: 4AEAEF23.6080505@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Pavel Stehule wrote:
> else
> {
> ereport(ERROR,
> (errcode(ERRCODE_INVALID_FUNCTION_DEFINITION),
> errmsg("function result type must be specified")));
> /* Alternative possibility: default to RETURNS VOID */
>
> /* WHY FOLOWING LINES? */
> prorettype = VOIDOID;
> returnsSet = false;
> }

To keep the compiler quiet about using the variables uninitialized. The
compiler doesn't know that ereport(ERROR) never returns.

--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2009-10-30 14:02:11 Re: CREATE TABLE ... INHERITS (parent INCLUDING xxx)
Previous Message Dave Page 2009-10-30 13:28:44 Re: FTP/GIT/WWW server move