Re: Adding \ev view editor?

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "David E(dot) Wheeler" <david(at)kineticode(dot)com>, Merlin Moncure <mmoncure(at)gmail(dot)com>, Josh Berkus <josh(at)agliodbs(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Adding \ev view editor?
Date: 2009-09-21 19:27:11
Message-ID: 4AB7D38F.8010206@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane wrote:
> Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
>
>> Tom Lane wrote:
>>
>>> It might be worth pointing out that what I don't want pg_dump doing
>>> is suppressing "useless" parentheses. Adding whitespace ought to be
>>> safe enough. So if anyone wanted to do the work of decoupling those
>>> two effects of the prettyprint option, we could have "semi pretty
>>> printed" output in pg_dump. Dunno if it's worth it.
>>>
>
>
>> The attached patch goes part of the way towards doing this, by adding
>> white space unconditionally to the target list of a viewdef.
>>
> I'd rather do that than add another pg_get_viewdef variant or option.
> That's not what I had in mind by "decoupling" the option's effects.
>
>
>

Well, regardless of that it does what I want, and with a fairly small
amount of code.

I can make it work only in the pretty print case, if that's your objection.

Like you I doubt that fully decoupling pretty printing parentheses and
whitespace is going to be worth the trouble.

cheers

andrew

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2009-09-21 19:27:35 Re: SELECT ... FOR UPDATE [WAIT integer | NOWAIT] for 8.5
Previous Message Robert Haas 2009-09-21 19:18:11 Re: SELECT ... FOR UPDATE [WAIT integer | NOWAIT] for 8.5