Paul Matthews <plm(at)netspace(dot)net(dot)au> wrote:
> Feedback appreciated.
+ /* As x is the larger value, this must be the correct answer.
Also
+ * avoids division by zero. */
+ if( x == 0.0 )
+ return 0.0;
+
+ /* Trivial case. */
+ if( y == 0.0 )
+ return x;
The first test seems unnecessary if you have the second.
x >= 0, so x can't be zero unless y is, too.
Returning x on y == 0.0 will return 0.0 whenever x == 0.0.
-Kevin