From: | Oliver Jowett <oliver(at)opencloud(dot)com> |
---|---|
To: | Maciek Sakrejda <msakrejda(at)truviso(dot)com> |
Cc: | pgsql-jdbc(at)postgresql(dot)org |
Subject: | Re: PGStream synchronization |
Date: | 2009-08-27 00:07:39 |
Message-ID: | 4A95CE4B.5050107@opencloud.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-jdbc |
Maciek Sakrejda wrote:
> I'm not really sure if there's another clean approach, though. I'm
> attaching a patch that takes another dirty approach, but other than
> the fact that it seems to work, I don't really like it at all. The
> basic idea is to cancel whatever you're doing before closing the
> connection: if there's an active copy, have the executor send a
> CopyFail; otherwise, have the ProtocolConnectionImpl request a query
> cancellation.
This seems a bit heavyweight because cancelling a query isn't a trivial
amount of work, and it'll happen whenever close() is called if I read
your patch correctly. 99% of apps are effectively single-threaded so it
seems expensive to always do this when it's rarely needed ..
-O
From | Date | Subject | |
---|---|---|---|
Next Message | Maciek Sakrejda | 2009-08-27 00:37:26 | Re: PGStream synchronization |
Previous Message | Maciek Sakrejda | 2009-08-27 00:03:44 | Re: Inserting 'large' amounts of data |